Repository navigation
test(credentials): use a non-token-shaped GitHub fixture so secret scanning stays quiet - #9876
Merged
Merged
Conversation
…anning stays quiet
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
 [Low impact] This fixture-only change appears safe to merge. SummaryReplaces the GitHub-shaped test fixture with
Reviews (1) · Last reviewed commit: "test(credentials): use a non-token-shape..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github_pat_11ABCDEFG0secretvalue. It's fake, but it matches GitHub's fine-grained token format, so GitGuardian flags every PR that merges staging. The validator sends any token asBearer, so the fixture doesn't need the prefix. It's nowtest-github-token.Type of Change
Testing
lib/credentials/token-service-accounts/validators/github.test.ts: 6 tests pass, including the checks that the token never appears in error details or messages.Checklist
test-auditauthoring gate)